Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import search setting from muon #2415

Closed
rebron opened this issue Dec 8, 2018 · 2 comments · Fixed by brave/brave-core#1064
Closed

import search setting from muon #2415

rebron opened this issue Dec 8, 2018 · 2 comments · Fixed by brave/brave-core#1064
Assignees
@bsclifton
Labels
feature/importer QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.58.x - Release ...

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 8, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1064

Description

User search setting set in muon should be imported upon update from muon. Importer should include an item for Search setting as option during manual import. This setting should be checked by default when user chooses to manually import from Brave (old).
@bsclifton
Copy link
Member

We should also import the DDG on private tabs setting

bsclifton added a commit to brave/brave-core that referenced this issue Dec 11, 2018
@bsclifton
Importer for Muon now imports search engine preferences
a662e11 
- default search engine
- use DDG/Qwant for private tabs
- use DDG/Qwant for Tor tabs

Fixes brave/brave-browser#2415
@bsclifton bsclifton mentioned this issue Dec 11, 2018
Merged
18 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Dec 13, 2018
@bsclifton
Importer for Muon now imports search engine preferences
d2e8388 
- default search engine
- use DDG/Qwant for private tabs
- use DDG/Qwant for Tor tabs

Fixes brave/brave-browser#2415

NOTE: if private tabs in tor is not set, TorWindowSearchEngineProviderService::GetInitialSearchEngineProvider will properly set the default
@bsclifton bsclifton added this to the 0.58.x - Release milestone Dec 13, 2018
@btlechowski btlechowski mentioned this issue Dec 18, 2018
Closed
@btlechowski
Copy link

btlechowski commented Dec 18, 2018 •
edited
Loading

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Used STR from brave/brave-core#1064

Reported: #2613

Verified passed with

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

Verification passed on

Brave 0.58.15 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

Used STR from brave/brave-core#1064

Reproduced: #2613

This was referenced Dec 19, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
feature/importer QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.58.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Import default search engine brave/brave-core
5 participants
@garrettr @bsclifton @rebron @LaurenWags @btlechowski