Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit media is being blocked by Brave Shields #1999

Closed
mil1i opened this issue Nov 5, 2018 · 14 comments
Closed

Reddit media is being blocked by Brave Shields #1999

mil1i opened this issue Nov 5, 2018 · 14 comments

Comments

@mil1i
Copy link

mil1i commented Nov 5, 2018

Description

Reddit now hosts it's own videos/gifs instead of using imgur, etc. Using the current Brave Dev build, media that is hosted by Reddit will not play unless Shields are disabled for the site.

Steps to Reproduce

  1. Visit www.reddit.com
  2. Locate a posted video hosted by reddit (https://www.reddit.com/r/Seattle/comments/9uhb5h/snoqualmie_falls_with_foliage_thanks_wa/)
  3. Video will not play while shields active.

Actual result:

Even just disabling Ads and Trackers blocked does not alleviate the issue. You must fully disable shields on reddit.com in order for the media to play. The below is one of the items listed as blocked. Not sure if the one below is an add, there was another from redditstatic.com that ends in ads.js that gets blocked as well.

https://www.redditmedia.com/gtm/jail?id=GTM-5XVNS82

Expected result:

Play media files posted on reddit.

Reproduces how often:

Every reddit hosted media item.

Brave version (brave://version info)

Brave | 0.57.4 Chromium: 71.0.3578.31 (Official Build) dev (64-bit)
Revision | c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Unsure.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Is the issue reproducible on the latest version of Chrome? No
@tildelowengrimm tildelowengrimm added webcompat/shields Shields is breaking a website. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 8, 2018
@bsclifton
Copy link
Member

bsclifton commented Nov 9, 2018

+1 from me

  1. Visit any link on Reddit with a video
  2. Try to watch video
  3. You may get an autoplay blocked notice in omnibox; Click and allow autoplay
  4. Nothing happens at all (even if you pause / resume video). Shields shows only Ads/Trackers being blocked
  5. Put shields down (I don't want to do this)
  6. Video now works fine

@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 13, 2018
@kjozwiak
Copy link
Member

+1 from me as well. Ran into the above using the dev version this weekend while browsing around reddit. Seems to affect both dev & beta but not release.

Release Channel: - PASSED

Brave 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

BETA Channel: - FAILED

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta(64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS Mac OS X

Dev Channel: - FAILED

Brave 0.57.4 Chromium: 71.0.3578.31 (Official Build) dev (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS Mac OS X

@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 28, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
@Brave-Matt
Copy link

+1 from many users (thread below). The thread itself is about imgur albums specifically, but I can confirm that any media uploaded to reddit will either not display or fail to upload all together.

This includes uploading imgur albums (wont upload or can't view), regular images to posts (upload does go through, but image isn't displayed in the post itself, and embedded videos.
Reddit thread: https://www.reddit.com/r/brave_browser/comments/a2uw8t/imgur_albums_on_reddit_still_broken_on_brave/

Also worth noting that this issue seems a bit inconsistent - some users report the same as me (nothing really works), some say it works for imgur albums but not for inserting media, etc.

@thanuj10
Copy link

+1 Here too.
Confirmed this bug is reproducible on Version 0.59.2 Dev build.

@Brave-Matt
Copy link

@kjozwiak
Copy link
Member

@rebron @bsclifton @bbondy we should fix this in 0.59.x. Makes using reddit under Brave pretty frustrating when a lot of the media can't be played within the browser.

@iefremov
Copy link
Contributor

Looks like this is a dupe of #2252
Reveting https://github.com/brave/brave-core/pull/754/files fixes it for me.

@Mister36MN
Copy link

This issue still occurs on 60.3 Dev

@Brave-Matt
Copy link

@iefremov
Copy link
Contributor

iefremov commented Jan 9, 2019

Should work now since #2252 is fixed.

@btlechowski
Copy link

btlechowski commented Jan 9, 2019

Verification passed on

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

image

Verified passed with

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • Reproduced issue on 0.58.18 with STR from description. Updated to 0.58.20 and verified video was able to play with default shields.

Verification PASSED on Mint 19.1 x64 VM using the following build:

Brave 0.58.20 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

@eixan
Copy link

eixan commented Jan 13, 2019

webm's on reddit won't play when you press the play button on reddit's interface.

Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)

@bergmul
Copy link

bergmul commented May 6, 2021

+1 on 1.24.82.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests