crash when clearing "Cached images and files" while IPFS enabled/running

[kjozwiak]

Description

Brave will crash once you initiate a Clear Data with Cached images and files enabled while IPFS is running. Reproduced the issue on both Win 10 x64 & macOS 11.1 x64. Crash report that I managed to retrieve from brave:/crashes (not sure if helpful):

https://brave.sp.backtrace.io/p/brave/triage?filters=(_rxid%3D%229b670000-604d-b505-0000-000000000000%22)&aggregations=((fingerprint%3Bissues%3Binvariants%2Chead)%2C(fingerprint%3Bissues%3Btags%2Chead)%2C(fingerprint%3Bissues%3Bticket%2Chead)%2C(fingerprint%3Bissues%3Bassignee%2Chead)%2C(fingerprint%3Bissues%3Bstate%2Chead)%2C(fingerprint%3Bfirst_seen%2Chead)%2C(callstack%2Chead)%2C(timestamp%2Cbin%2C32)%2C(timestamp%2Crange)%2C(uname.sysname%2Cdistribution%2C3)%2C(ver%2Cmax)%2C(ver%2Cmin)%2C(guid%2Cunique)%2C(classifiers%2Chead))&similarity=false

[ 00 ] ChromeBrowsingDataRemoverDelegate::OnTaskComplete(ChromeBrowsingDataRemoverDelegate::TracingDataType, unsigned long long, bool)
[ 01 ] base::internal::Invoker<base::internal::BindState<base::OnceCallback<void (bool)>, bool>, void ()>::RunOnce(base::internal::BindStateBase*)
[ 02 ] base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply(base::(anonymous namespace)::PostTaskAndReplyRelay)
[ 03 ] base::internal::Invoker<base::internal::BindState<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>, void ()>::RunOnce(base::internal::BindStateBase*)
[ 04 ] <name omitted>
[ 05 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*)
[ 06 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork()
[ 07 ] invocation function for block in base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
[ 08 ] base::mac::CallWithEHFrame(void () block_pointer)
[ 09 ] base::MessagePumpCFRunLoopBase::RunWorkSource(void*)
[ 10 ] 0x7fff20449a0c
[ 11 ] 0x7fff20449974
[ 12 ] 0x7fff204496ef
[ 13 ] 0x7fff20448121
[ 14 ] 0x7fff204476ce
[ 15 ] 0x7fff286cc6d0
[ 16 ] 0x7fff286cc4cc
[ 17 ] 0x7fff286cc1ef
[ 18 ] 0x7fff22c64de9
[ 19 ] 0x7fff22c635af
[ 20 ] __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke
[ 21 ] base::mac::CallWithEHFrame(void () block_pointer)
[ 22 ] -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]
[ 23 ] 0x7fff22c55b0a
[ 24 ] base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*)
[ 25 ] base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
[ 26 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta)
[ 27 ] <name omitted>
[ 28 ] ChromeBrowserMainParts::MainMessageLoopRun(int*)
[ 29 ] content::BrowserMainLoop::RunMainMessageLoopParts()
[ 30 ] content::BrowserMainRunnerImpl::Run()
[ 31 ] content::BrowserMain(content::MainFunctionParams const&)
[ 32 ] content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool)
[ 33 ] content::ContentMainRunnerImpl::Run(bool)
[ 34 ] content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*)
[ 35 ] content::ContentMain(content::ContentMainParams const&)
[ 36 ] ChromeMain
[ 37 ] main
[ 38 ] 0x7fff2036c621

Steps to Reproduce

1. download/install https://github.com/brave/brave-browser/releases/tag/v1.21.7
2. follow the STR outlined via Clear IPFS cache when clearing browsing data brave-core#7578 (comment)
3. once you attempt to clear the data using Cached images and files, you'll into the crash

Actual result:

Example of the crash occurring: https://youtu.be/slaDg1QN5Ss

Expected result:

Brave shouldn't be crashing when clearing data while IPFS is running/being used.

Reproduces how often:

100% reproducible when running through the STR mentioned above.

Brave version (brave://version info)

Brave | 1.21.7 Chromium: 88.0.4324.87 (Official Build) nightly (64-bit)
-- | --
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | Windows 10 OS Version 2009 (Build 19042.746)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bbondy @jueckstock @LaurenWags @rebron @bsclifton

[kjozwiak]

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.85 Chromium: 88.0.4324.89 (Official Build) (x86_64)
--- | ---
Revision | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS | macOS Version 11.1 (Build 20C69)

• Above issue was verified when running through the cases via Empty IPFS cache missing from Delete browsing data dialog #13302 (comment)
• ensured that Brave wasn't crashing when clearing data
  • checked brave://crashes and ensured that weren't any silent crashes that were logged

---

Verification passed on

Brave	1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
Revision	4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS	Ubuntu 18.04 LTS

• Above issue was verified when running through the cases via Empty IPFS cache missing from Delete browsing data dialog #13302 (comment)
• ensured that Brave wasn't crashing when clearing data

---

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.19.86 Chromium: 88.0.4324.96 (Official Build) (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2009 (Build 19042.746)

• Above issue was verified when running through the cases via Empty IPFS cache missing from Delete browsing data dialog #13302 (comment)
• ensured that Brave wasn't crashing when clearing data
  • checked brave://crashes and ensured that weren't any silent crashes that were logged