Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget] Remove back button when in token graph view #12277

Closed
srirambv opened this issue Oct 22, 2020 · 3 comments · Fixed by brave/brave-core#6942
Closed

[Widget] Remove back button when in token graph view #12277

srirambv opened this issue Oct 22, 2020 · 3 comments · Fixed by brave/brave-core#6942

Comments

@srirambv
Copy link
Contributor

Description

Two back buttons are shown when a token view is selected. Back button to token list can be missed as the back button to opt-in state is more obvious and can take back user to opt-in state instead of back to the token list

Steps to Reproduce

  1. Open Crypto.com widget
  2. Enable market view and select a token
  3. Two back buttons are shown one on top which and next to token

Actual result:

Screenshot 2020-10-22 at 16 00 55

Expected result:

Only have one back button on token graph view

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64 Bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/exclude feature/widgets OS/Desktop labels Oct 22, 2020
@ryanml ryanml self-assigned this Oct 23, 2020
@kjozwiak kjozwiak added this to the 1.16.x - Release milestone Oct 23, 2020
@kjozwiak
Copy link
Member

Adding release/blocking and moved into the 1.16.x milestone as we want this released with 1.16.x.

@GeetaSarvadnya
Copy link

Verification passed on


Brave | 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64-bit)
-- | --
Revision | b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS | Windows 10 OS Version 1903 (Build 18362.1139)


  • Reproduced the issue in 1.16.67
    image
  • Upgraded profile to 1.16.78 and ensured there is only one back arrow in the token graph view
    image

@srirambv
Copy link
Contributor Author

srirambv commented Oct 27, 2020

Verification passed on

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified back button is only shown in token list view and is hidden when token details is opened
    mac-widget

Verification passed on

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64 bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Windows 10 OS Version 1809 (Build 17763.1518)
  • Verified back button is only shown in token list view and is hidden when token details is opened
    win-widget

Verification passed on

Brave 1.16.68 Chromium: 86.0.4240.111 (Official Build) (64 bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Linux
  • Verified back button is only shown in token list view and is hidden when token details is opened
    linux-widgegt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment