Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm test-security should default to auditing dev dependencies #11748

Closed
diracdeltas opened this issue Sep 16, 2020 · 0 comments · Fixed by #11749
Closed

npm test-security should default to auditing dev dependencies #11748

diracdeltas opened this issue Sep 16, 2020 · 0 comments · Fixed by #11749
Assignees
@diracdeltas
Labels
dev-concern OS/Desktop QA/No release-notes/exclude security
Milestone
1.16.x - Release #1

Comments

@diracdeltas
Copy link
Member

see https://github.com/brave/devops/issues/3657 for details
@diracdeltas diracdeltas self-assigned this Sep 16, 2020
diracdeltas added a commit that referenced this issue Sep 16, 2020
@diracdeltas
Run audit_dev_deps by default in test-security
8332dcb 
Fix #11748
@diracdeltas diracdeltas mentioned this issue Sep 16, 2020
Merged
28 tasks
diracdeltas added a commit to brave/brave-core that referenced this issue Sep 17, 2020
@diracdeltas
Fix most npm audit errors, exclude advisory 1556
a04cabd 
Resolves 23 out of 33 npm audit errors using npm audit fix.
https://www.npmjs.com/advisories/1556 is ignored because there is no fix
in some of our dependencies, and it's a low-impact DoS vulnerability.

Fix brave/brave-browser#11732

Run audit_dev_deps in test-security script

Needed for brave/brave-browser#11748
diracdeltas added a commit to brave/brave-core that referenced this issue Sep 17, 2020
@diracdeltas
Fix most npm audit errors, exclude advisory 1556
6898964 
Resolves 23 out of 33 npm audit errors using npm audit fix.
https://www.npmjs.com/advisories/1556 is ignored because there is no fix
in some of our dependencies, and it's a low-impact DoS vulnerability.

Fix brave/brave-browser#11732

Run audit_dev_deps in test-security script

Needed for brave/brave-browser#11748
diracdeltas added a commit that referenced this issue Sep 18, 2020
@diracdeltas
sync test-security script with brave-core
a1ea3a4 
Fix #11748
diracdeltas added a commit that referenced this issue Sep 18, 2020
@diracdeltas
sync test-security script with brave-core
3021640 
Fix #11748
@diracdeltas diracdeltas added this to the 1.16.x - Nightly milestone Sep 21, 2020
deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
@diracdeltas @deeppandya
Fix most npm audit errors, exclude advisory 1556
1bd993b 
Resolves 23 out of 33 npm audit errors using npm audit fix.
https://www.npmjs.com/advisories/1556 is ignored because there is no fix
in some of our dependencies, and it's a low-impact DoS vulnerability.

Fix brave/brave-browser#11732

Run audit_dev_deps in test-security script

Needed for brave/brave-browser#11748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diracdeltas diracdeltas

Labels
dev-concern OS/Desktop QA/No release-notes/exclude security
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

sync test-security script with brave-core brave/brave-browser
1 participant
@diracdeltas