Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email subscriptions tracking #961

Merged
merged 6 commits into from
Sep 4, 2022
Merged

Add email subscriptions tracking #961

merged 6 commits into from
Sep 4, 2022

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Sep 4, 2022

From: https://github.com/AdguardTeam/AdguardFilters/blob/master/TrackParamFilter/sections/general_url.txt

! AdguardTeam/AdguardFilters#89869 ! email subscriptions tracking

$removeparam=bsft_clkid
$removeparam=bsft_eid
$removeparam=bsft_mid
$removeparam=bsft_uid
$removeparam=bsft_aaid
$removeparam=bsft_ek

! Matomo/Piwik

$removeparam=mtm_campaign
$removeparam=mtm_cid
$removeparam=mtm_content
$removeparam=mtm_group
$removeparam=mtm_keyword
$removeparam=mtm_medium
$removeparam=mtm_placement
$removeparam=mtm_source
$removeparam=pk_campaign
$removeparam=pk_medium
$removeparam=pk_source

! Branch.io ( https://stackoverflow.com/questions/37882810/what-is-meaning-of-branch-match-id )
$removeparam=_branch_match_id

! Valuecommerce ( https://help.valuecommerce.ne.jp/mer/dl/ITP2.0_for_iTAG.pdf )
$removeparam=vc_lpp

! brave/brave-browser#17507

$removeparam=ml_subscriber
$removeparam=ml_subscriber_hash

@ryanbr ryanbr added the params Url Paramerters label Sep 4, 2022
@ryanbr ryanbr self-assigned this Sep 4, 2022
@ryanbr ryanbr merged commit 5a03c52 into master Sep 4, 2022
@ryanbr ryanbr deleted the matomo branch September 4, 2022 09:01
ryanbr added a commit that referenced this pull request Sep 4, 2022
ryanbr added a commit that referenced this pull request Sep 4, 2022
@fmarier
Copy link
Member

fmarier commented Sep 6, 2022

@ryanbr If you see any entries that come from Brave (ml_subscriber and ml_subscriber_hash), then they don't need to be added to the clean-url list since they'll be removed automatically earlier.

They're not wrong, nor will they cause problems, they're just not necessary.

@pes10k
Copy link
Collaborator

pes10k commented Sep 6, 2022

just a thought, but you might want to leave them in the clean URL list (even if they're duplicates) is that we don't strip query parameters on same-site navigations, so there are at least possible cases where the query params are in the URL, but users still might want them removed.

@fmarier
Copy link
Member

fmarier commented Sep 6, 2022

Good point. I don't think it's going to matter in this particular case since they're email newsletter trackers (therefore will be cross-site), but it may in other cases.

@fmarier
Copy link
Member

fmarier commented Sep 7, 2022

PR to add the bsft ones to the main query filter: brave/brave-core#15008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
params Url Paramerters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants