-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email subscriptions tracking #961
Conversation
@ryanbr If you see any entries that come from Brave ( They're not wrong, nor will they cause problems, they're just not necessary. |
just a thought, but you might want to leave them in the clean URL list (even if they're duplicates) is that we don't strip query parameters on same-site navigations, so there are at least possible cases where the query params are in the URL, but users still might want them removed. |
Good point. I don't think it's going to matter in this particular case since they're email newsletter trackers (therefore will be cross-site), but it may in other cases. |
PR to add the bsft ones to the main query filter: brave/brave-core#15008 |
From: https://github.com/AdguardTeam/AdguardFilters/blob/master/TrackParamFilter/sections/general_url.txt
! AdguardTeam/AdguardFilters#89869 ! email subscriptions tracking
! Matomo/Piwik
! Branch.io ( https://stackoverflow.com/questions/37882810/what-is-meaning-of-branch-match-id )
$removeparam=_branch_match_id
! Valuecommerce ( https://help.valuecommerce.ne.jp/mer/dl/ITP2.0_for_iTAG.pdf )
$removeparam=vc_lpp
! brave/brave-browser#17507