Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incomplete Zoom rule. #863

Merged
merged 1 commit into from
May 25, 2022
Merged

Remove incomplete Zoom rule. #863

merged 1 commit into from
May 25, 2022

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented May 25, 2022

This is a follow-up to 818db9b.

For example:

  • https://st1.zoom.us/web_client/zsc0psq/html/externalLinkPage.html?ref=https://brave.com/privacy gets debounced properly using the existing action, but
  • https://st1.zoom.us/web_client/zsc0psq/html/externalLinkPage.html?ref=https//brave.com/privacy/#ads gets debounced to https://brave.com/privacy/ instead of the correct URL with #ads.

Basically Zoom fails to encode their URL parameters properly, or choose not to, on purpose.

These kinds of debounces will be handled once we have brave/brave-browser#22429.

@fmarier fmarier requested a review from ryanbr May 25, 2022 20:10
@fmarier fmarier self-assigned this May 25, 2022
@ryanbr ryanbr merged commit ad8a8c9 into master May 25, 2022
@ryanbr ryanbr deleted the remove-zoom-rule branch May 25, 2022 23:45
@fmarier fmarier added the Debounce Debouncing list related label May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debounce Debouncing list related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants