Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove googleadservices.com debounce #805

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Remove googleadservices.com debounce #805

merged 1 commit into from
Mar 24, 2022

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Mar 24, 2022

Removing this debounce, reportedly causing issues when clicking on ad links.

image (4)

@ryanbr ryanbr added the Debounce Debouncing list related label Mar 24, 2022
@ryanbr ryanbr merged commit 71cce91 into master Mar 24, 2022
@ryanbr ryanbr deleted the fix-goo branch March 24, 2022 06:46
@fmarier
Copy link
Member

fmarier commented May 26, 2022

@ryanbr Do you remember whether we were able to determine why this one broke?

From the screenshot, it looks like a pretty straightforward one to debounce (at least the first hop to clickserver.dartsearch.net). Was the the interaction with a second debounce rule that broke things?

@ryanbr
Copy link
Collaborator Author

ryanbr commented May 26, 2022

@fmarier https://bravesoftware.slack.com/archives/C2FQMN4AD/p1644940249798829 has most of details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debounce Debouncing list related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants