Skip to content
This repository has been archived by the owner on Jun 6, 2019. It is now read-only.

Adds memos to the state #46

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Adds memos to the state #46

merged 1 commit into from
Mar 22, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 22, 2018 •
edited
Loading

  • adds memos to the state
  • increase memo size from 5 to 10

@NejcZdovc NejcZdovc self-assigned this Mar 22, 2018
@NejcZdovc NejcZdovc requested a review from mrose17 March 22, 2018 23:00
mrose17
mrose17 suggested changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't you just use this throughout the function? generally, i use self only when this might be different in a scope.

@NejcZdovc NejcZdovc requested a review from mrose17 March 22, 2018 23:08
@NejcZdovc
Copy link
Contributor Author

changed to this

mrose17
mrose17 approved these changes Mar 22, 2018
View reviewed changes
Copy link
Contributor

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit de3fd33 into brave-intl:master Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrose17 mrose17 mrose17 approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @mrose17