This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
attempt at fixing race resulting in multiple in flight #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrose17
added a commit
that referenced
this pull request
Dec 19, 2017
* 2.0.5: add Client.prototype.publishersInfo For future use of batched REST call * Ensure that at most one _publishersInfo is active... …regardless of the number of alls to `publishersInfo` * Consistent style * attempt at fixing race resulting in multiple in flight (#34) LGTM. * All new edits! - Have up to 4 concurrent retrievals - Handle 429 responses - Extra check in `retrytrip` in case we never get a `response` object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrose17 would this work as a way to fix the race that can result in multiple calls to
_publishersInfoin flight simultaneously?