1.5.2: fix missing params init and add test for getPromotion

brave-intl · Nov 20, 2017 · 5c784c1 · 5c784c1
1 parent 4300724
commit 5c784c1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -679,6 +679,7 @@ Client.prototype.getPromotion = function (lang, callback) {
   const self = this
 
   let path, params, paymentId
+  params = {}
 
   if (self.options.version === 'v1') return
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bat-client",
-  "version": "1.5.1",
+  "version": "1.5.2",
   "description": "An example of client code for the BAT.",
   "main": "index.js",
   "scripts": {
@@ -32,7 +32,7 @@
     "@ambassify/backoff-strategies": "1.0.0",
     "bat-balance": "^1.0.4",
     "bat-publisher": "^1.3.0",
-    "bitgo": "4.12.0",
+    "bitgo": "^4.15.0",
     "brave-crypto": "0.0.1",
     "http-request-signature": "0.0.2",
     "joi": "^11.1.1",

diff --git a/test/integrationTest.js b/test/integrationTest.js
@@ -64,3 +64,15 @@ test('balance', async (t) => {
     })
   })
 })
+
+test('getPromotion', async (t) => {
+  t.plan(2)
+  const client = new Ledger(null, options)
+
+  client.sync(function () {
+    client.getPromotion(null, function (err, resp) {
+      t.false(err)
+      t.true(resp.hasOwnProperty('promotionId'))
+    })
+  })
+})