Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert incomplete deploy #121

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Revert incomplete deploy #121

merged 2 commits into from
Feb 21, 2025

Conversation

CJGlitter
Copy link
Member

@CJGlitter CJGlitter commented Feb 21, 2025 •
edited
Loading

Summary

Reverting last two commits to re-test the deploy workflow with updated NPM creds.

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

Reviewers

@braintree/team-sdk-js

@CJGlitter
Revert "ef482b2"
3c56bf5 
This reverts commit ef482b3.
@CJGlitter
Revert "de1b6da"
d99aee7 
This reverts commit de1b6da.
@CJGlitter CJGlitter marked this pull request as ready for review February 21, 2025 16:34
@CJGlitter CJGlitter requested a review from a team as a code owner February 21, 2025 16:34
GoogilyBoogily
GoogilyBoogily approved these changes Feb 21, 2025
View reviewed changes
Copy link

@GoogilyBoogily GoogilyBoogily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐸

mikenichols
mikenichols approved these changes Feb 21, 2025
View reviewed changes
Copy link

@mikenichols mikenichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@CJGlitter CJGlitter merged commit 72164ad into main Feb 21, 2025
2 checks passed
@CJGlitter CJGlitter deleted the revert-incomplete-deploy branch February 21, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenichols mikenichols mikenichols approved these changes

@GoogilyBoogily GoogilyBoogily GoogilyBoogily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CJGlitter @mikenichols @GoogilyBoogily