improve read_with_dask docs, ignore OME metadata #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
read_with_dask
, when the metadata for all tiffs is specified in a single tiff's metadata.read_with_dask
lack return value and parameters in docsread_with_dask
ignores.tiff
files (only finds.tif
files).What does this PR do?
Ignores the OME metadata, so we can correctly read OME tiff files with dask. Also improvements to docs and ability to read
.tiff
files lazily, and better error handling.References
Closes #79
How has this PR been tested?
Locally by @niksirbi and me
Is this a breaking change?
I don't think so.
Does this PR require an update to the documentation?
Docstrings updated.
Checklist:
we would need to make, or download, suitable data to test this on. I tried but only got so far, this will be addressed separately later (
ignore-ome-test
branch in #99 )- so we can useread_with_dask
for more urgent work. I did add a negative test for a new error that is now being raised.