Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Twig template to be compatible with 2.7 (#377) #378

Closed
wants to merge 3 commits into from
Closed

Upgraded Twig template to be compatible with 2.7 (#377) #378

wants to merge 3 commits into from

Conversation

althaus
Copy link
Contributor

@althaus althaus commented Jun 3, 2015

This updates the bundle to Symfony 2.7

@manuonet
Copy link

manuonet commented Jun 4, 2015

hi i got a problem with the 2.7 upgrade and Twig optimizer :

PHP Fatal error: Uncaught exception 'InvalidArgumentException' with message 'Optimizer mode "" is not valid.' in /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/NodeVisitor/Optimizer.php:44\nStack trace:\n#0 /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/Extension/Optimizer.php(25): Twig_NodeVisitor_Optimizer->__construct(NULL)\n#1 /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/Environment.php(1252): Twig_Extension_Optimizer->getNodeVisitors()\n#2 /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/Environment.php(1197): Twig_Environment->initExtension(Object(Twig_Extension_Optimizer))\n#3 /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/Environment.php(1130): Twig_Environment->initExtensions()\n#4 /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/Lexer.php(367): Twig_Environment->getUnaryOperators()\n#5 /home/notroot/www/sign.groupeonet.com/vendor/twig/twig/lib/Twig/Lexer.php(65): Twig_Lexer->getOperatorRegex()\n#6 /home/notroot/www/sign.group in /home/notroot/www/sign.groupeonet.com/vendor/symfony/symfony/src/Symfony/Bundle/TwigBundle/Controller/ExceptionController.php on line 37

@althaus
Copy link
Contributor Author

althaus commented Jun 4, 2015

@manuonet Using my modified Twig template? Hmm... I just copied the changes from the Symfony files.

@althaus
Copy link
Contributor Author

althaus commented Jun 4, 2015

@florianeckerstorfer Give me a note, if you prefer squashed commits.

@manuonet
Copy link

manuonet commented Jun 4, 2015

Hi
Thanks a lot for your help. But I think I made a mistake when I choose your post.
Have a nice day

De : Matthias Althaus [mailto:notifications@github.com]
Envoyé : jeudi 4 juin 2015 12:46
À : braincrafted/bootstrap-bundle
Cc : Tesson Emmanuel
Objet : Re: [bootstrap-bundle] Upgraded Twig template to be compatible with 2.7 (#377) (#378)

@florianeckerstorferhttps://github.com/florianeckerstorfer Give me a note, if you prefer squashed commits.


Reply to this email directly or view it on GitHubhttps://github.com//pull/378#issuecomment-108836660.

@Restless-ET
Copy link
Contributor

@florianeckerstorfer I believe this can be closed now that #382 has been merged. :)

PS- Unless you prefer to change the minimum required version of Symfony to 2.7.

@althaus althaus closed this Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants