Convert datatype #68
Closed
Convert datatype #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradymholt
reviewed
Oct 11, 2023
src/extension.ts
Outdated
| @@ -31,6 +31,9 @@ export function getFormattedText( | |||
| if (config.keywordCase != null) { | |||
| formattingOptions.keywordCase = CaseOptionEnum[<keyof typeof CaseOptionEnum>config.keywordCase]; | |||
| } | |||
| if (config.datatypeCase != null) { | |||
| formattingOptions.keywordCase = CaseOptionEnum[<keyof typeof CaseOptionEnum>config.datatypeCase]; | |||
There was a problem hiding this comment.
Have to tried it with this change? I doubt it would work since you're just overriding the keywordCase option, which passes --keyword-case to pgFormatter. But, it looks like you want --data-type option to be passed.
There was a problem hiding this comment.
Yeah you right. Need use type-case
-U | --type-case N : Change the case of the data type name. Default is
lowercase: 1. Values: 0=>unchanged, 1=>lowercase,
2=>uppercase, 3=>capitalize.
There was a problem hiding this comment.
Sorry i undestand what you mean
You use psqlformat(https://github.com/bradymholt/psqlformat) but in that lib not defined type-case
There was a problem hiding this comment.
Implement type-case
from https://github.com/darold/pgFormatter
for https://github.com/bradymholt/psqlformat#options
|
Closing in lieu of #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add converter for datatype