Deprecate tzOffset option
#336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
tzOffsetand indicates the feature will be removed in a future release. If a value is specified for this option, a console warning will be printed -'tzOffset' option has been deprecated and will be removed in a future release..My original aim for this project was to keep it fairly simple and focus simply on describing a cron expression into language. Features such as timezone manipulation (as well as 'next' occurrence determination, full expression validation, etc.) take the project in a more complex direction and I would like to avoid this.
This issue: #313 brought to light that proper support for
tzOffsetrequires significantly more careful handling when the offset causes a wrap in hour, day, etc. Thinking through the details, I realized this is not something I want this project to be handling anymore.I know there will be folks that are disappointed with this change and I understand that. There is always the option to continue using an older version of cRonstrue that supports
tzOffset, once it is fully removed in a future release.Fixes #313