Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] For #6093: Added button to show all results in a list #5567

Open
core-ai-bot opened this issue Aug 30, 2021 · 30 comments
Open

[CLOSED] For #6093: Added button to show all results in a list #5567

core-ai-bot opened this issue Aug 30, 2021 · 30 comments

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Sunday Nov 24, 2013 at 18:51 GMT
Originally opened as adobe/brackets#6099

This PR adds a button to show all results in a list, as requested in #6093.
Including:

  • Make the find-counter clickable
  • New string (title attribute of find-counter)

@peterflynn

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/6099/commits
@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Nov 24, 2013 at 19:38 GMT

Nice feature. The new button might need to be put in another place if something like this is done in the Find/Replace UI Cleanup card, and I might also just call it "Find All". But@larz0 would have a better opinion on that.

To Show the status bar, try calling modalBar.close(true, animate); before calling the command.

I am not sure why the busy indicator is not hiding, since it should hide it after the search is done.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Tuesday Jan 07, 2014 at 20:12 GMT

@peterflynn@larz0 Do we still need this after the Find/Replace overhaul?

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Mar 02, 2014 at 18:14 GMT

@peterflynn@larz0 I'm asking again, do we still need this?
I'd like to fit it into the new Find/Replace bar.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Mar 02, 2014 at 18:49 GMT

I wouldn't add this to Find/Replace. I think this could go in Find in Files, by changing the in project text to be a select, where you select the scope, and File can be one of the. I am planning on try this eventually.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Mar 02, 2014 at 19:20 GMT

But it seems illogical to do Find in Files in order to search just one file.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Sunday Mar 02, 2014 at 19:31 GMT

@TomMalbran You can already do Find In Files in a single file by right-clicking on file in project tree and using Find in....

@SAPlayer sometimes it helps to see the list of hits for a single file in the bottom panel.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Mar 02, 2014 at 19:36 GMT

@redmunds I know, but you can't do a search in the Working Set yet, and sometimes is easier to press ctrl+shift+f and then make it search on the currently selected folder/file.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Sunday Mar 02, 2014 at 19:49 GMT

Just make the find-result at the end of the find input a blue "link" that opens up the bottom panel. This will reduce clutter and it also gives context. Would be nice to be able to tab to it as well.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Sunday Mar 02, 2014 at 20:18 GMT

I'd like an option to "Find in Working Set Files"

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Mar 02, 2014 at 22:43 GMT

@redmunds Wonderful idea!

@larz0 So should I carry on with this?

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Sunday Mar 02, 2014 at 22:52 GMT

I had a Find in Working Set Files command implemented in #3151. So I should get to it in one of the next Find in Files Improvements iteration. But instead of just a command, I thought it might be nice to be able to change the scope inside the find in files bar too.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Sunday Mar 02, 2014 at 23:15 GMT

Yes, that's a good idea and the way Visual Studio (2013) does it:
Visual Studio 2013
(current block, selection, current doc, all opened docs (similar to Working Files), current project, all projects)

@core-ai-bot
Copy link
Member Author

Comment by larz0
Sunday Mar 02, 2014 at 23:43 GMT

@saplayer I think you should go ahead with that. For all the other drop down items we could put them on top of search history drop down items if we ever get them.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Mar 03, 2014 at 01:40 GMT

Just pushed a commit (sorry, the old ones got lost) to make this PR up-to-date.
The only thing missing is an icon for the button.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Mar 03, 2014 at 13:16 GMT

Another not-so-cool thing: The same search is done twice. Would be better to just pass the results to fill the list.
@TomMalbran Looks like your #7059 (I don't really understand it, sorry) is introducing a new way to fill a search results panel, so it might be the best to wait for that to land in master.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 21:19 GMT

@SAPlayer this was what I meant (see screenshot), we don't need an extra button:

screen shot 2014-03-03 at 1 18 37 pm

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Mar 03, 2014 at 21:34 GMT

If it will be just a link on the search numbers, I would add it to replace too.

@SAPlayer I din't think it is a problem to do a double search. Replace All already search again to get the necessary information. If the highlight info had the necessary information and was stored to be later used, maybe we could use #7059 with some modifications to create the Find All Results class, but seems like a small optimization to be worth it, at least for now.

BTW, I think we should also increase the maximum number of results from a single file, which is hardcoded at 300.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 21:44 GMT

Yes. All search numbers should be clickable.

@redmunds here's the idea for Find in Working Files that I mentioned previously. I've included find history.

brackets_finddropdown_001

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Mar 03, 2014 at 21:50 GMT

@larz0 For find in Working Set, besides adding a new commands, I was thinking of replacing the in project text when doing a Find in Files with a dropdown button, to change between the possible options. But that would only go in Find in Files.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 22:02 GMT

@TomMalbran should we just use the Find/Replace UI for Find/Replace in Files?

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Mar 03, 2014 at 22:06 GMT

Next commit online.
I hope this one is right as I'm gonna be on vacation until Sunday. Feel free to do changes on your own.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Mar 03, 2014 at 22:08 GMT

@larz0 Do you mean using one command for all 3? It pops up the find/replace modalbar which does the same as now, but you could also use it for find/replace in files? If yes, it might be hard to place everything, including the exceptions and more options, unless we end up using 2 lines.

If not, the bars would look similar, but not exactly the same. Since the modalbar closes after doing the search, the arrows are not required, and the replace buttons would be just one, which means that there might be extra space for the scope and filters dropdowns.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 22:14 GMT

Sounds good. Not one command for all three but just the same Replace UI with the filter instead of the arrows.

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Mar 03, 2014 at 22:21 GMT

I am not sure, might look weird to have it in the history popdown. There is also the Find In... that shows the scope next to the search input. Maybe we could place this in the space used to show the results count inside the input?

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 22:27 GMT

Hmm I'll need to think about that a bit more. It could be hard to scale.

screen shot 2014-03-03 at 2 25 14 pm

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Mar 03, 2014 at 22:30 GMT

@TomMalbran The Find in... can get quite long (imagine src/node_modules/grunt/...) so it's not a good idea to do that.
But here are some impressions from Visual Studio again:
Find
image

Replace
image
Yes, they got a simple, but functional Find/Replace UI.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 22:31 GMT

@SAPlayer this is awesome. Just need to add cursor: pointer to the number of the matches and make it so that we can get to it via keyboard using tab. For the focus ring style see focus ring of links in the extension manager.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Monday Mar 03, 2014 at 22:33 GMT

I were just about to make this change ;)
Adding a title attribute as well.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Monday Mar 03, 2014 at 22:34 GMT

w00T!

@core-ai-bot
Copy link
Member Author

Comment by TomMalbran
Monday Mar 03, 2014 at 22:35 GMT

I know, but it will need to be cut at some point, or the filters dropdown will end up not being visible in not too wide screens. It will get even worst when adding the replace input and button. We can just show the entire text when opening the dropdown. We could also not add the replace input in the modal bar, and just add it in the find in files results, to have more space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot