[CLOSED] REVIEW ONLY: Add ability to create multiple global key handlers #3829
Comments
|
|
|
|
|
I didn't think of that explicitly, but I do think this fix might make possible to get rid of that hack, since we're now handling these key events in the code hint list during the capture phase and preventing KeyBindingManager from executing associated commands if we handle it. But even if he doesn't remove that hack, this fix will still work. |
|
Fixes pushed, ready for re-review. |
|
Looks good. Merging. |
Wednesday Jun 05, 2013 at 23:33 GMT
Originally opened as adobe/brackets#4110
This is an alternate fix for #3975. It creates a more general mechanism for dealing with multiple global capture handlers for keydown.
I think this is a cleaner fix than #4032, and it has the advantage that we can also use this same mechanism to simplify the nested-dialog key handling in Dialogs.js. However, it is somewhat more invasive (though I don't think it's necessarily more risky than #4032 if we can convince ourselves that the logic is correct).
The semantics of these new global keydown handlers is a bit tricky. The idea is that you can install multiple global keydown handlers, with the last-added one running first. Any of these handlers can return true in order to indicate that it handled the key. However, this does not have the same effect as the usual event
stopPropagation()/preventDefault(); all it does is prevent the other global keydown handlers (including KeyBindingManager itself) from running. The desired intention is that this is the way modal/semi-modal key handling should work: only one modal should get to deal with the key, but it should be able to decide that the key should go through normal event handling (bypassing other modals further down the stack, including ordinary key bindings).Also note that this introduces a subtle change in how keys are handled by code hints. It used to be that key events while the code hint list is up would come from CodeMirror, passed into CodeHintManager, and from there to the CodeHintList. Now, CodeHintList itself installs a global capture handler for the key events it cares about. I think this actually makes more sense, since the CodeHintList is basically a semi-modal UI, and should be trapping these key events directly, rather than relying on them coming from the editor.
I tested various cases to try to verify that this is working properly:
njx included the following code: https://github.com/adobe/brackets/pull/4110/commits
The text was updated successfully, but these errors were encountered: