[CLOSED] Some preparatory work for incremental update

[core-ai-bot]

Issue by njx
Thursday Jun 20, 2013 at 07:43 GMT
Originally opened as adobe/brackets#4293

---

@dangoor

The first commit is straightforward--just adds an id->node map at the root of the DOM tree.

The second commit refactors the various edit tests to basically run them twice: once doing a full diff, the other capturing the changelist from the editor and passing that into _updateDOM(), making sure that we get the right tree edits in both cases. These tests still pass even though I haven't actually added the incremental update code yet, since the changelist is just ignored, so the "incremental" test is really just running the full diff again.

Not sure if you want to take that second one, but if it makes sense to you, I thought it would be good to go ahead and get this in so any new tests you write for editing functionality can follow the same pattern.

(Note that I made another change to the tests, to store any values from previousDOM that we want to test before actually doing the update. This is anticipating the fact that if we change the DOMUpdater in the way I suggested in my email to you, we can't compare to previousDOM after the update has occurred, since it will have been mutated to become the new DOM anyway.)

---

njx included the following code: https://github.com/adobe/brackets/pull/4293/commits

[core-ai-bot]

Comment by dangoor
Thursday Jun 20, 2013 at 13:02 GMT

---

Yeah, it makes sense to land all of this.