Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] [quick doc] Should not have cryptic looking title in quick doc for "box-shadow" property. #3313

Open
core-ai-bot opened this issue Aug 29, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by RaymondLim
Sunday Apr 21, 2013 at 17:47 GMT
Originally opened as adobe/brackets#3527


  1. Invoke quick doc for box-shadow.
  2. Look at the second title of the right side content.

Result: It looks like a regular expression syntax with some url, but I can't figure out what this paragraph is for.

@core-ai-bot
Copy link
Member Author

Comment by njx
Sunday Apr 21, 2013 at 19:14 GMT


It looks like this is a MediaWiki link. When parsing these, we should probably just pull the title out. Not sure why this wasn't properly translated to HTML for us though.

Also, it's weird that we're showing the attributes in a different order from the wiki. The attribute order actually matters (since this is describing a shorthand)--we should figure out if there's a general bug here.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Sunday Apr 21, 2013 at 22:34 GMT


@njx Good catch on the order of property values. I compared the order of property values (between quick docs and the corresponding web pages) for several properties, most of them turn out to be in the opposite order. I logged it as a new issue #3530.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 22, 2013 at 01:16 GMT


It might be the case that we only run the body text fields through the MediaWiki->HTML conversion API, and not the smaller header/title fields.

Not sure if this should go to@adrocknaphobia to fix in the JSON generation code or if we should try to handle this syntax on the client.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Apr 22, 2013 at 17:34 GMT


Assigning to@adrocknaphobia so we can answer the question in my last comment.

@core-ai-bot
Copy link
Member Author

Comment by adrocknaphobia
Monday Apr 29, 2013 at 05:26 GMT


Removed the link from wp.org (it wasn't useful). Will be fixed with new css.json. Leaving open until merge.

@core-ai-bot
Copy link
Member Author

Comment by RaymondLim
Monday Apr 29, 2013 at 16:33 GMT


Fix confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant