Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[quick doc] Should not have cryptic looking title in quick doc for "box-shadow" property. #3527

Closed
RaymondLim opened this issue Apr 21, 2013 · 6 comments
Assignees
Milestone

Comments

@RaymondLim
Copy link
Contributor

  1. Invoke quick doc for box-shadow.
  2. Look at the second title of the right side content.

Result: It looks like a regular expression syntax with some url, but I can't figure out what this paragraph is for.

@njx
Copy link

njx commented Apr 21, 2013

It looks like this is a MediaWiki link. When parsing these, we should probably just pull the title out. Not sure why this wasn't properly translated to HTML for us though.

Also, it's weird that we're showing the attributes in a different order from the wiki. The attribute order actually matters (since this is describing a shorthand)--we should figure out if there's a general bug here.

@RaymondLim
Copy link
Contributor Author

@njx Good catch on the order of property values. I compared the order of property values (between quick docs and the corresponding web pages) for several properties, most of them turn out to be in the opposite order. I logged it as a new issue #3530.

@peterflynn
Copy link
Member

It might be the case that we only run the body text fields through the MediaWiki->HTML conversion API, and not the smaller header/title fields.

Not sure if this should go to @adrocknaphobia to fix in the JSON generation code or if we should try to handle this syntax on the client.

@peterflynn
Copy link
Member

Assigning to @adrocknaphobia so we can answer the question in my last comment.

@ghost ghost assigned adrocknaphobia Apr 22, 2013
@adrocknaphobia
Copy link
Contributor

Removed the link from wp.org (it wasn't useful). Will be fixed with new css.json. Leaving open until merge.

@RaymondLim
Copy link
Contributor Author

Fix confirmed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants