[CLOSED] Exported Resizer DIRECTION_* and POSITION_* constants

[core-ai-bot]

Issue by WebsiteDeveloper
Friday Mar 29, 2013 at 18:28 GMT
Originally opened as adobe/brackets#3290

---

Fix for #3271.

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/3290/commits

[core-ai-bot]

Comment by jbalsas
Friday Mar 29, 2013 at 18:47 GMT

---

@WebsiteDeveloper Changes look good. I just have one concern. If you dig inside Resizer, you'll see that POSITION_BOTTOM and POSITION_LEFT aren't actually implemented (there's currently no use case in Brackets for them).

We probably shouldn't expose them yet, or if we do, we'd probably want to add an error log in makeResizable to warn that this won't work. Of course, a third option is to go ahead and implement it ;)

@redmunds I think you reviewed this back in the day... what do you think?

[core-ai-bot]

Comment by redmunds
Friday Mar 29, 2013 at 18:55 GMT

---

I agree that things that have not yet been implemented should not be exposed.

[core-ai-bot]

Comment by WebsiteDeveloper
Friday Mar 29, 2013 at 18:58 GMT

---

i'll just remove the exports for those and if i have time i'll look at implementing them, and then reexporting ;)

[core-ai-bot]

Comment by jbalsas
Friday Mar 29, 2013 at 19:07 GMT

---

Looks good! Merging