[CLOSED] Externalize strings from Extension Manager view item template #3271
Comments
|
Also, note that I changed "by" and "on" to "Author:" and "Date:". I figured that the new design might separate these various fields out, so having them be prepositions wasn't necessarily going to make sense; also, due to word order differences in foreign languages, it was risky to rely on prepositions to express these relationships (especially since they aren't all coming out of a master string format that can reorder things). |
|
Assigned to me |
|
Mostly minor comments. Could probably merge as-is, but I'll wait until tomorrow in case I don't hear from |
|
Fixed the version checking to indicate whether a newer or older version of Brackets is needed. (It wasn't completely straightforward because While testing this I also noticed that I wasn't actually properly forcing the Extension Manager to retrieve the registry every time you open the dialog (which we want to do)--both because I wasn't actually passing the parameter to tell it to do so, and because passing |
|
|
|
Oh, I also changed "Brackets" to |
|
I'm a little conflicted about c465213 for a couple of reasons.
In general, I think that doing any parsing of version requirements outside of the semver module is asking for trouble. The other thing I thought of with respect to this change is that we have the ability to actually offer earlier versions of an extension that may be compatible. If you look at the registry data, you'll see things like this: "versions":[{"version":"1.0.2","published":"2013-04-10T18:21:27.058Z","brackets":">0.20.0"}]For each version of an extension, we keep track of Brackets compatibility. So, it's possible that the most recent version is not compatible, but the user could install the previous version. That is a feature that can be added later, though. I just mention it because checking All of that said, I think the code here covers the common cases and won't blow up in the uncommon ones. I think the UX of hinting that a newer version of Brackets or an update to the extension is needed is better than just saying "It doesn't work" and is probably worthwhile. For the purposes of string freeze, I think it's fine to take this code. But, I think that we should ultimately:
|
|
|
|
Looks good. Merging. |
Friday Apr 19, 2013 at 00:37 GMT
Originally opened as adobe/brackets#3483
Note that the template references the strings as
{{Strings.STRING_KEY}}instead of just{{STRING_KEY}}. This is because each item is rendered separately, so it seemed worth it to avoid copying all the strings into the context object for each item, as opposed to just pointing to the entire Strings object in a subfield of the context.njx included the following code: https://github.com/adobe/brackets/pull/3483/commits
The text was updated successfully, but these errors were encountered: