[CLOSED] KeyBindingManager no longer warns / prevents binding collisions

[core-ai-bot]

Issue by peterflynn
Monday Mar 04, 2013 at 00:24 GMT
Originally opened as adobe/brackets#3032

---

Place the following code in an extension:

KeyBindingManager.addBinding(Commands.FILE_OPEN_FOLDER, "Ctrl-E");

Result: Quick Edit binding is silently overwritten. No console warnings.

Expected: We used to print warning messages and ignore the attempt at overwriting the binding. KeyBindingManager._addBinding() still contains several bits of code that seem like they should do this, but the logic has gotten pretty convoluted so I'm not sure in which cases they'll run anymore.

[core-ai-bot]

Comment by peterflynn
Monday Mar 04, 2013 at 00:25 GMT

---

Here's the original repro case, slightly trickier, that I found in the Clojure extension:

    KeyBindingManager.addBinding(Commands.FILE_OPEN_FOLDER, [
        {
            "key": "Ctrl-E"
        },
        {
            "key": "Cmd-E",
            "platform": "mac"
        }
    ]);

[core-ai-bot]

Comment by njx
Wednesday Mar 06, 2013 at 18:51 GMT

---

Reviewed. Low priority to@dangoor

[core-ai-bot]

Comment by jasonsanjose
Monday Mar 11, 2013 at 21:39 GMT

---

FBNC@peterflynn. We still allow platform-specific overrides to clobber a generic binding, but not the other way around.@WebsiteDeveloper's fix will show errors in the case you've described here as well when clobbering a generic binding with another generic binding.

[core-ai-bot]

Comment by peterflynn
Wednesday Sep 04, 2013 at 23:14 GMT

---

We certainly do warn now, though not always at the right times -- see #4265 for more up to date discussion. Closing this one.

[core-ai-bot]

Comment by redmunds
Thursday Sep 05, 2013 at 16:06 GMT

---

Verified that this is fixed in pull request adobe/brackets#5066.