Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run eslint #6

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Run eslint #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@
"@phosphor/widgets": "^1.6.0",
"@types/d3": "^5.7.2",
"@types/webpack-env": "^1.13.6",
"@typescript-eslint/eslint-plugin": "^3.6.0",
"@typescript-eslint/parser": "^3.6.0",
"@typescript-eslint/eslint-plugin": "^4.29.3",
"@typescript-eslint/parser": "^4.29.3",
"acorn": "^7.2.0",
"css-loader": "^3.2.0",
"eslint": "^7.4.0",
"eslint-config-prettier": "^6.11.0",
"eslint-plugin-prettier": "^3.1.4",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-prettier": "^3.4.1",
"fs-extra": "^7.0.0",
"identity-obj-proxy": "^3.0.0",
"mkdirp": "^0.5.1",
Expand Down
2 changes: 1 addition & 1 deletion src/LinesGLView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export class LinesGLView extends Lines {
}

renderGL() {
var fig = this.parent;
const fig = this.parent;

const x_scale = this.scales.x ? this.scales.x : this.parent.scale_x;
const y_scale = this.scales.y ? this.scales.y : this.parent.scale_y;
Expand Down
32 changes: 16 additions & 16 deletions src/ScatterGLView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ class AttributeParameters {
class ColorAttributeParameters extends AttributeParameters {
constructor(
array: TypedArray,
item_size: number = 1,
mesh_per_attribute: number = 1,
normalized: boolean = false,
use_colormap: boolean = true
item_size = 1,
mesh_per_attribute = 1,
normalized = false,
use_colormap = true
) {
super(array, item_size, mesh_per_attribute, normalized);
this.use_colormap = use_colormap;
Expand All @@ -126,10 +126,10 @@ class ColorAttributeParameters extends AttributeParameters {
class SelectionAttributeParameters extends AttributeParameters {
constructor(
array: TypedArray,
item_size: number = 1,
mesh_per_attribute: number = 1,
normalized: boolean = false,
use_selection: boolean = true
item_size = 1,
mesh_per_attribute = 1,
normalized = false,
use_selection = true
) {
super(array, item_size, mesh_per_attribute, normalized);
this.use_selection = use_selection;
Expand Down Expand Up @@ -652,7 +652,7 @@ export class ScatterGLView extends Mark {
value: THREE.InstancedBufferAttribute,
value_previous: THREE.InstancedBufferAttribute,
new_parameters: AttributeParameters,
animate: boolean = true,
animate = true,
after_animation: Function = () => {}
) {
if (animate) {
Expand Down Expand Up @@ -727,7 +727,7 @@ export class ScatterGLView extends Mark {
this.transition(set, after_animation, this);
}

updateX(rerender: boolean = true) {
updateX(rerender = true) {
const x_array = to_float_array(this.model.get('x'));

const new_markers_number = Math.min(x_array.length, this.y.array.length);
Expand All @@ -749,7 +749,7 @@ export class ScatterGLView extends Mark {
}
}

updateY(rerender: boolean = true) {
updateY(rerender = true) {
const y_array = to_float_array(this.model.get('y'));

const new_markers_number = Math.min(this.x.array.length, y_array.length);
Expand Down Expand Up @@ -791,7 +791,7 @@ export class ScatterGLView extends Mark {
}
}

updateColor(rerender: boolean = true) {
updateColor(rerender = true) {
const color_parameters = this.getColorAttributeParameters();
this.color = this.updateAttribute('color', this.color, color_parameters);
this.color.normalized = color_parameters.normalized;
Expand All @@ -804,7 +804,7 @@ export class ScatterGLView extends Mark {
}
}

updateOpacity(rerender: boolean = true) {
updateOpacity(rerender = true) {
const opacity_parameters = this.getOpacityAttributeParameters();
[this.opacity, this.opacity_previous] = this.updateAttributes(
'opacity',
Expand All @@ -818,7 +818,7 @@ export class ScatterGLView extends Mark {
}
}

updateSize(rerender: boolean = true) {
updateSize(rerender = true) {
const size_parameters = this.getSizeAttributeParameters();
[this.size, this.size_previous] = this.updateAttributes(
'size',
Expand All @@ -832,7 +832,7 @@ export class ScatterGLView extends Mark {
}
}

updateRotation(rerender: boolean = true) {
updateRotation(rerender = true) {
const rotation_parameters = this.getRotationAttributeParameters();
[this.rotation, this.rotation_previous] = this.updateAttributes(
'rotation',
Expand All @@ -846,7 +846,7 @@ export class ScatterGLView extends Mark {
}
}

updateSelected(rerender: boolean = true) {
updateSelected(rerender = true) {
const selected_parameters = this.getSelectedAttributeParameters();
this.selected = this.updateAttribute(
'selected',
Expand Down
Loading