fix: adjusted DataAssociation model to match bpmn spec #91
Conversation
|
Looking around I didn't see specific testing of the name property, is this something that needs to be done here, or is it a bit redundant? |
|
Any fix we shall apply via a transform from the original BPMN 2.0 meta-model. Please add a test case, i.e. verify that a BPMN 2.0 spec compliant diagram with the name property on a data-association can be read and serialized. |
Revert "fix: adjusted DataAssociation model to match spec" This reverts commit e2f16be. squash
4817954 to
ffc1d6d
Compare
There was a problem hiding this comment.
Let's also add a test case to the write tests and the roundtrip tests so that we are sure the fix works fine. The roundtrip tests verify that a serialized diagram is a valid BPMN according to the XSD schema.
|
Following discussions with @barmac, we have discovered that this issue is actually a bug in the bpmn specs. The pdf spec allows for the name, but the xml spec does not. Our approach is hence going to change here, as we do not want to support something which is potentially going to break other vendor's tools. We will use the XML as the true spec and instead change the properties panel to not anymore expose the name property. If my reasoning is appropriate, I am going to close this PR. @nikku @pinussilvestrus any objections? |
|
@Skaiir Exactly. The XML schema has to be our reference here, no matter what the PDF says. |
Related to camunda/camunda-modeler#2333
The spec reasons for this are referenced by our contributor on the above issue.