feat: select participant by click but not move #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
May 17, 2022
| @@ -68,6 +68,12 @@ BpmnInteractionEvents.prototype.createParticipantHit = function(element, gfx) { | |||
| // remove existing hits | |||
| this._interactionEvents.removeHits(gfx); | |||
|
|
|||
| // add body hit | |||
| this._interactionEvents.createBoxHit(gfx, 'no-move', { | |||
There was a problem hiding this comment.
Incredible, actually we had all infrastructure in place already. Know your tooling I guess (which I forgot about) 😸.
7c8f098 to
69dbec1
Compare
69dbec1 to
a90c26f
Compare
|
Ready for review. |
nikku
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
no-movehit boxes to the subprocess, participant, and lane shapes.Related to camunda/camunda-modeler#2859
Requires bpmn-io/diagram-js#638 to be merged and released.
Test with: