Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cron expressions for timer cycle props #772

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Support cron expressions for timer cycle props #772

merged 2 commits into from
Sep 22, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Sep 21, 2022

@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team September 21, 2022 09:11
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Sep 21, 2022
@barmac barmac mentioned this pull request Sep 21, 2022
Closed
philippfromme
philippfromme approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we'd have a shared component similar to src/provider/shared/ExtensionPropertiesProps. There's a lot of code duplication. But it works for now. ✔️

@barmac barmac merged commit c0ed15e into master Sep 22, 2022
@barmac barmac deleted the cron branch September 22, 2022 09:25
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@marstamm marstamm Awaiting requested review from marstamm marstamm was automatically assigned from bpmn-io/modeling-dev

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmac @philippfromme