-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zeebe:Properties
Support
#745
Conversation
d328568
to
f296fe9
Compare
910deca
to
1036071
Compare
Is this ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we test optional
binding, i.e. entry only being created if non-empty?
4925649
to
9c3c496
Compare
I added the missing tests. CI should be green in a minute. |
Thanks. Also coverage is happy now! :) |
Where exactly did you add the tests 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional does not work as expected.
In fact I could reproduce using output logging (#747) that an empty optional property npm run start:cloud-templates
is still serialized.
I'll look into that. |
@nikku I'm not sure what you mean. Do you mean that a property with |
@philippfromme Exactly. Empty fields (according to our optional behavior) shall not be serialized. Mirrors |
d0ab636
to
27faba6
Compare
Okay, implemented. |
* share extension properties group between Platform 7 and 8
27faba6
to
c879295
Compare
Verified optional entry change via 0d75f18. Looks good to me. |
Changes
Closes #731