Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use inherits #645

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Do not use inherits #645

merged 2 commits into from
Mar 30, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Mar 30, 2022

Usage of inherits was introduced without installing https://www.npmjs.com/package/inherits dependency. Thus, the Node.js internal inherits was used which is not being polyfilled when bundling. Instead of installing the dependency the usage of inherits can be avoided altogether.

@barmac barmac requested a review from philippfromme March 30, 2022 12:20
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 30, 2022
@philippfromme philippfromme changed the title deps: remove inherits Do not use inherits Mar 30, 2022
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@philippfromme philippfromme merged commit 6a870a2 into master Mar 30, 2022
@philippfromme philippfromme deleted the rm-inherits-dependency branch March 30, 2022 12:43
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants