Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zeebe): mark CalledDecision.id as feel: optional #643

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(zeebe): mark CalledDecision.id as feel: optional #643

merged 1 commit into from
Mar 30, 2022

Conversation

marstamm
Copy link
Contributor

closes #639

@marstamm marstamm requested a review from a team March 30, 2022 05:59
@marstamm marstamm self-assigned this Mar 30, 2022
@marstamm marstamm requested review from pinussilvestrus and smbea and removed request for a team March 30, 2022 05:59
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 30, 2022
nikku
nikku approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it is supposed to do.

@fake-join fake-join bot merged commit e9cf7a4 into master Mar 30, 2022
@fake-join fake-join bot deleted the 639-calledDecision-feel branch March 30, 2022 06:34
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 30, 2022
@philippfromme philippfromme mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus pinussilvestrus was automatically assigned from bpmn-io/modeling-dev

@smbea smbea Awaiting requested review from smbea smbea was automatically assigned from bpmn-io/modeling-dev

Assignees

@marstamm marstamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field CalledDecision.ID does not carry the Optionally can be a FEEL expression marker
2 participants
@marstamm @nikku