Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(render): display template name in header #627

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Mar 25, 2022

Closes #610

Displays the element template name as element type in the properties panel header.

image

Script to try it out

npx @bpmn-io/sr bpmn-io/bpmn-js-properties-panel#610-template-name-header -c "npm run start:cloud-templates"

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 25, 2022
@pinussilvestrus pinussilvestrus force-pushed the 610-template-name-header branch from 4202e20 to 19eeb6d Compare March 28, 2022 08:26
@pinussilvestrus pinussilvestrus marked this pull request as ready for review March 28, 2022 08:29
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 28, 2022
@pinussilvestrus pinussilvestrus requested review from a team, marstamm, MaxTru and currandwyer and removed request for a team March 28, 2022 08:29
@pinussilvestrus pinussilvestrus force-pushed the 610-template-name-header branch from 19eeb6d to 11c1425 Compare March 28, 2022 09:32
@pinussilvestrus pinussilvestrus requested a review from MaxTru March 28, 2022 09:34
@pinussilvestrus
Copy link
Contributor Author

@currandwyer If everything looks fine to you, let's merge 👍

@MaxTru
Copy link
Contributor

MaxTru commented Mar 29, 2022

Already looking forward to seeing this in the nightly :-)

Copy link

@currandwyer currandwyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Niklas, making tons of progress!

@fake-join fake-join bot merged commit 7b611db into master Mar 29, 2022
@fake-join fake-join bot deleted the 610-template-name-header branch March 29, 2022 06:55
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better distinguish template tasks from plain service tasks
3 participants