Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: render components instead of elements #590

Merged
merged 7 commits into from
Feb 23, 2022
Merged

feat: render components instead of elements #590

merged 7 commits into from
Feb 23, 2022

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Feb 21, 2022 •
edited
Loading

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Feb 21, 2022
@philippfromme philippfromme mentioned this pull request Feb 21, 2022
Merged
@philippfromme philippfromme marked this pull request as ready for review February 22, 2022 21:03
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 22, 2022
barmac
barmac requested changes Feb 23, 2022
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments but it looks good generally.

src/provider/camunda-platform/CamundaPlatformPropertiesProvider.js Outdated Show resolved Hide resolved
src/provider/camunda-platform/properties/ListenerProps.js Outdated Show resolved Hide resolved
src/provider/camunda-platform/properties/ListenerProps.js Outdated Show resolved Hide resolved
@philippfromme philippfromme mentioned this pull request Feb 23, 2022
Merged
@philippfromme philippfromme requested a review from barmac February 23, 2022 13:43
@fake-join fake-join bot merged commit d91eca4 into master Feb 23, 2022
@fake-join fake-join bot deleted the spike-refactoring branch February 23, 2022 13:48
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @barmac