Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C7 Template groups #563

Merged
merged 2 commits into from
Feb 3, 2022
Merged

C7 Template groups #563

merged 2 commits into from
Feb 3, 2022

Conversation

pinussilvestrus
Copy link
Contributor

Related to camunda/camunda-modeler#2673
This needs camunda/element-templates-json-schema#39 to be released + integrated.

This adds the basic grouping feature for C7 element templates.

image

@pinussilvestrus pinussilvestrus requested review from a team, philippfromme and barmac and removed request for a team January 28, 2022 12:56
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 28, 2022
@pinussilvestrus pinussilvestrus force-pushed the 2673-template-groups branch 2 times, most recently from bd3d37b to d66df1f Compare January 31, 2022 18:46
@MaxTru
Copy link
Contributor

MaxTru commented Feb 2, 2022

To consider: #564 (comment)

MaxTru
MaxTru approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #564

@fake-join fake-join bot merged commit a275f44 into master Feb 3, 2022
@fake-join fake-join bot deleted the 2673-template-groups branch February 3, 2022 12:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru MaxTru approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme philippfromme was automatically assigned from bpmn-io/modeling-dev

@barmac barmac Awaiting requested review from barmac barmac was automatically assigned from bpmn-io/modeling-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinussilvestrus @MaxTru