Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: give properties table inputs a unique identifier #466

Merged
merged 1 commit into from
Apr 16, 2021
Merged

fix: give properties table inputs a unique identifier #466

merged 1 commit into from
Apr 16, 2021

Conversation

pinussilvestrus
Copy link
Contributor

Closes #407

@pinussilvestrus pinussilvestrus requested review from a team, philippfromme and barmac and removed request for a team April 16, 2021 09:08
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 16, 2021
@pinussilvestrus
Copy link
Contributor Author

Don't have an impact on our side since we don't rely on this identifier, but it's good to clean up console warnings.

@fake-join fake-join bot merged commit 5cff189 into master Apr 16, 2021
@fake-join fake-join bot deleted the 407-dom-warning-extensions branch April 16, 2021 10:00
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a way to lose the DOM warning when adding a Property in the Extensions tab?
2 participants
@pinussilvestrus @barmac