Support multiple tab providers #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the PropertiesPanel#registerProvider method that allows users
to register custom properties providers.
A provider must have one of the following signatures:
({ getTabs: (element) => any[] }) // returns / overrides existing tabs
({ getTabs: (element) => (any[]) => any[] }); // may modify the existing
tabs (i.e. monkey patch) and return the updated tabs
Related to camunda/camunda-modeler#1992
There was a problem hiding this comment.
I really like that 👏
I created an example plugin to verify it works with the Camunda Modeler: https://github.com/pinussilvestrus/properties-provider-plugin-example. Super smooth to update the tabs 👍
I'd go for merging it, but I'm also ok to wait for another voice to review it. The next step would then be to update the element-templates-modal plugin to consume the new API.
|
Aaa, I was searching for the place the Camunda Modeler hooks into the properties panel. Thanks for the 👉. |
|
If you think it is fine, please add your 👍. We generally practice four eyes, not many eyes 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a tab provider mechanism similar to the one we bpmn-js uses for palette and context pad.
Required by camunda/camunda-modeler#1992.