fix(element-templates): always log id and name with validation error #432
+80
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16e60a5 to
ff4d040
Compare
There was a problem hiding this comment.
One little comment. Besides, I pretty much like the better logging 👍
I bother a bit that we now pipe the template through all validation methods, but I guess there is no real opportunity to improve it - especially if we reduce the validator by using the JSON schema directly, some day.
test/spec/provider/camunda/element-templates/ElementTemplatesLoaderSpec.js
Outdated
Show resolved
Hide resolved
ff4d040 to
79c7cac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
fix upstream camunda/camunda-modeler#2111
fix upstream camunda/camunda-modeler#2038 (duplication by accident)
Acceptance Criteria
Definition of Done