Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEEL] When I copy the FEEL expression, the expression type is not copied #728

Closed
marstamm opened this issue Jul 19, 2022 · 2 comments · Fixed by #746
Closed

[FEEL] When I copy the FEEL expression, the expression type is not copied #728

marstamm opened this issue Jul 19, 2022 · 2 comments · Fixed by #746
Assignees
@marstamm
Labels
bug Something isn't working

Comments

@marstamm
Copy link
Contributor

Describe the Bug

When I copy values from FEEL fields, the starting equal sign is missing

Recording 2022-07-19 at 11 17 53

Steps to Reproduce

  1. Copy Value from a feel field
  2. paste it into another field
  3. The FEEL type is copied

Expected Behavior

  • FEEL is automatically enabled on the field

Environment

  • Host (Browser/Node version), if applicable: Chrome
  • OS: [e.g. Windows 7]
  • Library version: dev
@marstamm marstamm added bug Something isn't working backlog Queued in backlog labels Jul 19, 2022
@marstamm marstamm self-assigned this Jul 19, 2022
@marstamm
Copy link
Contributor Author

Solution Sketch:

Have a second mime type for FEEL fields application/FEEL, that allows us to toggle FEEL on when pasting content from another FEEL field. This way, the expected paste behavior (e.g. into notepad/emails) is not affected

@marstamm marstamm added the ready Ready to be worked on label Aug 2, 2022 — with bpmn-io-tasks
@marstamm marstamm removed the backlog Queued in backlog label Aug 2, 2022
@marstamm
Copy link
Contributor Author

Solved by bpmn-io/properties-panel#174

@marstamm marstamm added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Aug 30, 2022
nikku added a commit that referenced this issue Sep 1, 2022
@nikku
deps: update to @bpmn-io/properties-panel@0.20.0
9186cfa 
Closes #728
@nikku nikku mentioned this issue Sep 1, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Sep 1, 2022
@fake-join fake-join bot closed this as completed in a354b95 Sep 2, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 2, 2022
marstamm pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Jun 8, 2023
@nikku @fake-join
deps: update to @bpmn-io/properties-panel@0.20.0
9303843 
Closes bpmn-io/bpmn-js-properties-panel#728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marstamm marstamm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

House keeping bpmn-io/bpmn-js-properties-panel
1 participant
@marstamm