Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for BottomSlideNotification #40

Merged
merged 7 commits into from
May 24, 2020
Merged

Conversation

gilescm
Copy link
Contributor

@gilescm gilescm commented May 24, 2020

Hi,

This PR covers the new implementation of #39 which removes references to SnackBar and updates implementation to use position which can be NotificationPosition.top or NotificationPosition.bottom.

Giles Correia Morton added 6 commits May 22, 2020 11:20
Additionally remove references to SnackBar in comments etc, as the behaviours of `BottomSlideNotification` and `SnackBar` are notably different.
@boyan01
Copy link
Owner

boyan01 commented May 24, 2020

Thanks.

I run this pr in local and found a small problem... it seems that BottomSlideNotification has a addition top padding.

Screenshot_1590326630

This extra padding is caused by this line of code.

Maybe in the bottom notification mode, should we remove this TopPadding? Or do you have a better idea ?

@gilescm
Copy link
Contributor Author

gilescm commented May 24, 2020

Oh good find! Sorry I should've noticed that before.

After some investigation the extra padding was also caused by SafeArea defaulting its parameter top=true. I've updated both bottom and top parameters so that the correct amount of padding is created for the two different positions of the notification, and bottom=false is maintained when using NotificationPosition.top.

@boyan01
Copy link
Owner

boyan01 commented May 24, 2020

Looks Good To Me. Thank you very much for your contribution.

@boyan01 boyan01 merged commit 673d3b3 into boyan01:master May 24, 2020
@gilescm
Copy link
Contributor Author

gilescm commented May 24, 2020

Great thanks. No problem I'm very happy to contribute!

@EArminjon
Copy link

Hi !

When will be available this new version :) !

@boyan01
Copy link
Owner

boyan01 commented May 25, 2020

@EArminjon 1.0.4 Published just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants