-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for BottomSlideNotification
#40
Conversation
Additionally remove references to SnackBar in comments etc, as the behaviours of `BottomSlideNotification` and `SnackBar` are notably different.
Thanks. I run this pr in local and found a small problem... it seems that This extra padding is caused by this line of code.
Maybe in the bottom notification mode, should we remove this TopPadding? Or do you have a better idea ? |
Oh good find! Sorry I should've noticed that before. After some investigation the extra padding was also caused by |
Looks Good To Me. Thank you very much for your contribution. |
Great thanks. No problem I'm very happy to contribute! |
Hi ! When will be available this new version :) ! |
@EArminjon 1.0.4 Published just now. |
Hi,
This PR covers the new implementation of #39 which removes references to
SnackBar
and updates implementation to useposition
which can beNotificationPosition.top
orNotificationPosition.bottom
.