Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLO flow #128

Merged
merged 18 commits into from
Mar 30, 2022
Merged

SLO flow #128

merged 18 commits into from
Mar 30, 2022

Conversation

devkiran
Copy link
Contributor

@devkiran devkiran commented Mar 22, 2022 •
edited
Loading

What does this PR do?

Add the SLO

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Create a logout create using createRequest({ nameId, tenant, product, redirectUrl })

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ghost
Copy link

ghost commented Mar 22, 2022 •
edited by ghost
Loading

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

deepakprabhakara
deepakprabhakara reviewed Mar 23, 2022
View reviewed changes
@devkiran devkiran marked this pull request as ready for review March 25, 2022 09:47
@devkiran devkiran requested a review from a team March 25, 2022 09:48
@deepakprabhakara
Merge branch 'main' into slo
c14146f 
# Conflicts:
#	lib/jackson.ts
#	npm/src/index.ts
deepakprabhakara
deepakprabhakara approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@deepakprabhakara deepakprabhakara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll want to start moving things to saml20 at some point

@deepakprabhakara deepakprabhakara merged commit 39d1309 into main Mar 30, 2022
@deepakprabhakara deepakprabhakara deleted the slo branch March 30, 2022 10:52
@deepakprabhakara deepakprabhakara mentioned this pull request Apr 4, 2022
Closed
@dnoliver dnoliver mentioned this pull request Jan 3, 2024
Closed
@deepakprabhakara deepakprabhakara mentioned this pull request Apr 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakprabhakara deepakprabhakara deepakprabhakara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkiran @deepakprabhakara