Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Update phantomjs to 1.9.7 #14

Merged
merged 1 commit into from
Mar 27, 2014
Merged

Update phantomjs to 1.9.7 #14

merged 1 commit into from
Mar 27, 2014

Conversation

craigw
Copy link
Contributor

@craigw craigw commented Mar 19, 2014

This should get rid of this [1] anoing CoreText warning.

[1] ariya/phantomjs#11418

This should get rid of this [1] anoing CoreText warning.

[1] ariya/phantomjs#11418
@craigw
Copy link
Contributor Author

craigw commented Mar 19, 2014

Addresses #13

@rafaelfranca
Copy link
Member

Do we need to define a class for that?

You can use in your project phantomjs::version { '1.9.7': }

@craigw
Copy link
Contributor Author

craigw commented Mar 19, 2014

When using boxen::project like this:

boxen::project { 'foo':
  phantomjs => '1.9.7'
}

the manifest ends up requiring this class via a call to phantomjs::local: https://github.com/boxen/puppet-phantomjs/blob/master/manifests/local.pp#L16

rafaelfranca added a commit that referenced this pull request Mar 27, 2014
Update phantomjs to 1.9.7
@rafaelfranca rafaelfranca merged commit 3d3aaa9 into boxen:master Mar 27, 2014
@rafaelfranca rafaelfranca mentioned this pull request Mar 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants