Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change marker from long to string #359

Merged
merged 8 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions content/attributes/marker_pagination_string_based.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
type: object

description: |-
The part of an API response that describes marker
based pagination

properties:
limit:
description: |-
The limit that was used for these entries. This will be the same as the
`limit` query parameter unless that value exceeded the maximum value
allowed. The maximum value varies by API.
example: 1000
type: integer
format: int64

next_marker:
description: |-
The marker for the start of the next page of results.
example: JV9IRGZmieiBasejOG9yDCRNgd2ymoZIbjsxbJMjIs3kioVii
type: string

prev_marker:
description: |-
The marker for the start of the previous page of results.
example: JV9IRGZmieiBasejOG9yDCRNgd2ymoZIbjsxbJMjIs3kioVih
type: string
2 changes: 1 addition & 1 deletion content/responses/recent_items.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description: |-
A list of recent items.

allOf:
- $ref: "../attributes/marker_pagination.yml"
- $ref: "../attributes/marker_pagination_string_based.yml"
- properties:
entries:
type: array
Expand Down
10 changes: 4 additions & 6 deletions openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -30849,15 +30849,13 @@
},
"next_marker": {
"description": "The marker for the start of the next page of results.",
"example": 3000,
"type": "integer",
"format": "int64"
"example": "JV9IRGZmieiBasejOG9yDCRNgd2ymoZIbjsxbJMjIs3kioVii",
"type": "string"
},
"prev_marker": {
"description": "The marker for the start of the previous page of results.",
"example": 1000,
"type": "integer",
"format": "int64"
"example": "JV9IRGZmieiBasejOG9yDCRNgd2ymoZIbjsxbJMjIs3kioVih",
"type": "string"
}
}
},
Expand Down