feat: Prompt a question before removing the output directory when extracting a PHAR

src/Console/Command/Extract.php

@@ -23,9 +23,12 @@
 use Phar;
 use PharData;
 use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Question\ConfirmationQuestion;
 use Throwable;
 use UnexpectedValueException;
+use function file_exists;
 use function KevinGH\Box\FileSystem\copy;
+use function KevinGH\Box\FileSystem\mkdir;
 use function KevinGH\Box\FileSystem\remove;
 use function realpath;
 use function sprintf;
@@ -69,6 +72,27 @@ public function execute(IO $io): int
             return ExitCode::FAILURE;
         }
 
+        if (file_exists($outputDir)) {
+            $canDelete = $io->askQuestion(
+                new ConfirmationQuestion(
+                    'The output directory already exists. Do you want to delete its current content?',
+                    // If is interactive, we want the prompt to default to false since it can be an error made by the user.
+                    // Otherwise, this is likely launched by a script or Pharaoh in which case we do not care.
+                    !$io->isInteractive(),
+                ),
+            );
+
+            if ($canDelete) {
+                remove($outputDir);
+            // Continue
+            } else {
+                // Do nothing
+                return ExitCode::FAILURE;
+            }
+        }
+
+        mkdir($outputDir);
+
         self::dumpPhar($pharPath, $outputDir);
 
         return ExitCode::SUCCESS;

tests/Console/Command/ExtractTest.php

@@ -21,6 +21,7 @@
 use KevinGH\Box\Test\RequiresPharReadonlyOff;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Finder\SplFileInfo;
+use function count;
 use function KevinGH\Box\FileSystem\make_path_relative;
 
 /**
@@ -56,12 +57,14 @@ public function test_it_can_extract_a_phar(
         string $pharPath,
         array $expectedFiles,
     ): void {
+        $this->commandTester->setInputs(['yes']);
         $this->commandTester->execute(
             [
                 'command' => 'extract',
                 'phar' => $pharPath,
                 'output' => $this->tmp,
             ],
+            ['interactive' => false],
         );
 
         $actualFiles = $this->collectExtractedFiles();
@@ -117,6 +120,83 @@ private static function pharProvider(): iterable
         ];
     }
 
+    /**
+     * @dataProvider confirmationQuestionProvider
+     */
+    public function test_it_asks_confirmation_before_deleting_the_output_dir(
+        bool $outputDirExists,
+        bool $interactive,
+        bool $input,
+        bool $expectedToSucceed,
+    ): void {
+        $outputDir = $outputDirExists ? $this->tmp : $this->tmp.'/subdir';
+
+        $this->commandTester->setInputs([$input ? 'yes' : 'no']);
+        $this->commandTester->execute(
+            [
+                'command' => 'extract',
+                'phar' => self::FIXTURES.'/simple-phar.phar',
+                'output' => $outputDir,
+            ],
+            ['interactive' => $interactive],
+        );
+
+        $actualFiles = $this->collectExtractedFiles();
+
+        if ($expectedToSucceed) {
+            self::assertSame(ExitCode::SUCCESS, $this->commandTester->getStatusCode());
+            self::assertGreaterThan(0, count($actualFiles));
+        } else {
+            self::assertSame(ExitCode::FAILURE, $this->commandTester->getStatusCode());
+            self::assertSame(0, count($actualFiles));
+        }
+    }
+
+    public static function confirmationQuestionProvider(): iterable
+    {
+        yield 'exists; accept' => [
+            true,
+            true,
+            true,
+            true,
+        ];
+
+        yield 'exists; refuse' => [
+            true,
+            true,
+            false,
+            false,
+        ];
+
+        yield 'does not exist: the question is not asked' => [
+            false,
+            true,
+            false,
+            true,
+        ];
+
+        yield 'exists; not interactive; accept' => [
+            true,
+            false,
+            true,
+            true,
+        ];
+
+        yield 'exists; not interactive; refuse' => [
+            true,
+            false,
+            false,
+            true,
+        ];
+
+        yield 'not interactive; does not exist: the question is not asked' => [
+            false,
+            false,
+            false,
+            true,
+        ];
+    }
+
     /**
      * @dataProvider invalidPharPath
      */
@@ -132,6 +212,7 @@ public function test_it_cannot_extract_an_invalid_phar(
                     'phar' => $pharPath,
                     'output' => $this->tmp,
                 ],
+                ['interactive' => false],
             );
 
             self::fail('Expected exception to be thrown.');