Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare composer-plugin-api compatibility #496

Merged
merged 3 commits into from
Nov 29, 2020
Merged

Declare composer-plugin-api compatibility #496

merged 3 commits into from
Nov 29, 2020

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented Nov 8, 2020 •
edited
Loading

  • If there will be a need to drop Composer 1.x compatibility, it will be as easy as one line change.
  • This might break the package on some very old releases of Composer. Not as .phar though.

@theofidry
Copy link
Member

👍 for the change; @sanmai could you rebase your PR?

@theofidry
Copy link
Member

Actually there is no conflict so updating it may be enough

@theofidry theofidry merged commit 14b9717 into box-project:master Nov 29, 2020
@theofidry
Copy link
Member

Thank you @sanmai, sorry for the delay

@sanmai sanmai deleted the pr/2020-11/composer-plugin-api branch November 30, 2020 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanmai @theofidry