Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate files #42

Merged
merged 16 commits into from
Jan 27, 2018
Merged

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Jan 27, 2018

Aggregate files

Nothing changes configuration-wise for the user, but the Configuration class is drastically simplified by aggregating all the files (files, directories, finders accounting for the blacklist) and doing the same for the binary files.

When building a PHAR in very verbose mode, all the files where listed. This is no longer done as will no longer be doable in the future (at least easily) when refactoring the Box class to build from an iterator rather than handling a file by file case in the Build command.

Other notable changes:

  • Fix the usage of the blackfilter with absolute path: it now matches the real file paths to know if a file should be excluded or not
  • Fix the usage of the blackfilter with base paths: the base path is now applied to the files listed in the blackfilter as well
  • files and files-bin now works with absolute paths
  • files and files-bin now throws a user-friendly error when a file does not exists or is a directory instead of a file
  • directories and directories-bin now works with absolute paths
  • directories and directories-bin now throws a user-friendly error when a directory does not exists or is a file instead of a directory
  • updated the documentation
  • Fix base-path usage when superfluous spaces are used in the path (trim the path)
  • Do not allow a string value for the blacklist anymore
  • Fix blacklist usage when superfluous spaces are used in the paths (trim the paths)
  • Fix files(-bin) usage when superfluous spaces are used in the paths (trim the paths)
  • Fix directories(-bin) usage when superfluous spaces are used in the paths (trim the paths)
  • Fix finder(-bin) usage when superfluous spaces are used in the paths or method names (trim the paths & method names)
  • Fix finder(-bin) usage with the exclude method: normalize the paths like done for in
  • Fix finder(-bin) usage with the append method:
    • pass an array instead of doing X calls
    • normalize the paths like done for in
  • Fix usage with redundant files: files are included once and only once: not duplicate is allowed (except if a file is present both as a regular file & binary file)

Nothing changes configuration-wise for the user, but the Configuration
class is drastically simplified by aggregating all the files (files,
directories, finders accounting for the blacklist) and doing the same
for the binary files.

When building a PHAR in very verbose mode, all the files where listed.
This is no longer done as will no longer be doable in the future (at
least easily) when refactoring the Box class to build from an iterator
rather than handling a file by file case in the Build command.
@theofidry theofidry force-pushed the refactor/aggregate-files branch from de6f405 to 3a272ca Compare January 27, 2018 18:34
@theofidry theofidry merged commit 62a0ddb into box-project:master Jan 27, 2018
@theofidry theofidry deleted the refactor/aggregate-files branch January 27, 2018 18:54
@theofidry theofidry mentioned this pull request Jan 28, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant