-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate files #42
Merged
theofidry
merged 16 commits into
box-project:master
from
theofidry:refactor/aggregate-files
Jan 27, 2018
Merged
Aggregate files #42
theofidry
merged 16 commits into
box-project:master
from
theofidry:refactor/aggregate-files
Jan 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing changes configuration-wise for the user, but the Configuration class is drastically simplified by aggregating all the files (files, directories, finders accounting for the blacklist) and doing the same for the binary files. When building a PHAR in very verbose mode, all the files where listed. This is no longer done as will no longer be doable in the future (at least easily) when refactoring the Box class to build from an iterator rather than handling a file by file case in the Build command.
de6f405
to
3a272ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregate files
Nothing changes configuration-wise for the user, but the Configuration class is drastically simplified by aggregating all the files (files, directories, finders accounting for the blacklist) and doing the same for the binary files.
When building a PHAR in very verbose mode, all the files where listed. This is no longer done as will no longer be doable in the future (at least easily) when refactoring the Box class to build from an iterator rather than handling a file by file case in the Build command.
Other notable changes:
blackfilter
with absolute path: it now matches the real file paths to know if a file should be excluded or notblackfilter
with base paths: the base path is now applied to the files listed in the blackfilter as wellfiles
andfiles-bin
now works with absolute pathsfiles
andfiles-bin
now throws a user-friendly error when a file does not exists or is a directory instead of a filedirectories
anddirectories-bin
now works with absolute pathsdirectories
anddirectories-bin
now throws a user-friendly error when a directory does not exists or is a file instead of a directoryexclude
method: normalize the paths like done forin
append
method:in