Fix the main script inclusion #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the main script requires some special processing and is added before the regular and binary files, it should not be included in the regular or binary files. This was actually the case when the main script was included via `files`, `files-bin` and `append` (from `finder` or `finder-bin`). The main script path is now properly excluded in such cases. Closes box-project#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the main script requires some special processing and is added before the regular and binary
files, it should not be included in the regular or binary files.
This was actually the case when the main script was included via
files,files-binandappend(from
finderorfinder-bin). The main script path is now properly excluded in such cases.Closes #168