Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(requirement-checker): Improve the required PHP version required message #1119

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

danepowell
Copy link
Contributor

When you try to run an application with an incompatible PHP version, the language isn't as clear as it could be:

The application requires a version matching 8.2

"Version 8.2 of what?" is the question most users will inevitably ask 😄

Additionally, I think "this application requires" is slightly more natural sounding than "the application requires"

@danepowell
Copy link
Contributor Author

Little annoying that make test can pass locally and then a bunch of stuff still fails in CI

@danepowell
Copy link
Contributor Author

This should be good to go. I think tests are just failing because of rate limiting.

@theofidry
Copy link
Member

Little annoying that make test can pass locally and then a bunch of stuff still fails in CI

Tell me about it... Also had it failing from one github job from another (restarting the job worked). I think part of the issue can be with how git handles binary files; not quite sure. Ideally everything would be ran in docker contains but then you're probably looking to go from 1-2min from local tests to 30min given the amount of IO there is

@theofidry theofidry changed the title Improve PHP version requirement language feat(requirement-checker): Improve the required PHP version required message Oct 23, 2023
@theofidry theofidry merged commit 2d8daf1 into box-project:main Oct 23, 2023
@theofidry
Copy link
Member

Thank you @danepowell!

For the remaining tests I assume it's diff not working as expected (again), but I'm not sure why tbh. Probably a combination of different terminal length or a different GNU diff being used... I would really love for this to be fixed but didn't figure out a way yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants