Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress composer.lock files #219

Closed
theofidry opened this issue May 16, 2018 · 0 comments
Closed

Compress composer.lock files #219

theofidry opened this issue May 16, 2018 · 0 comments
Labels
Milestone

Comments

@theofidry
Copy link
Member

The JSON compactor skips the composer.lock files since it does not have the .json extension. This could be fixed

@theofidry theofidry added the bug label May 17, 2018
theofidry added a commit to theofidry/box that referenced this issue May 19, 2018
Fix the compactors order:
- Run the PHP Compactor before PHP-Scoper which can remove the useless spaces since will print again
  each file
- Compress the JSON files after PHP-Scoper since PHP-Scoper will pretty print the scoped JSON files

Also ensure that the JSON compactor can compress the `composer.lock` files.

Closes box-project#219
theofidry added a commit that referenced this issue May 19, 2018
Fix the compactors order:
- Run the PHP Compactor before PHP-Scoper which can remove the useless spaces since will print again
  each file
- Compress the JSON files after PHP-Scoper since PHP-Scoper will pretty print the scoped JSON files

Also ensure that the JSON compactor can compress the `composer.lock` files.

Closes #219
@theofidry theofidry added this to the 3.0.0 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant