Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful failure on missing extension for compression #186

Closed
theofidry opened this issue May 1, 2018 · 0 comments
Closed

Graceful failure on missing extension for compression #186

theofidry opened this issue May 1, 2018 · 0 comments
Milestone
3.0.0

Comments

@theofidry
Copy link
Member

theofidry commented May 1, 2018 •
edited
Loading

When a PHAR needs to be compressed it will require a dependency on the compression algorithm used for building the PHAR and executing the PHAR. The user may not have the necessary extension and Box should fail gracefully in this case.

  • Phar::GZ => requires the zlib extension
  • Phar::BZ2 => requires the bz2 extension
@theofidry theofidry mentioned this issue May 4, 2018
Merged
theofidry added a commit that referenced this issue May 4, 2018
@theofidry
Fail gracefully when the extension required for the compression algor…
26b3f48 
…ithm is not loaded (#205)

- Add a warning in the documentation and the logs of the `compile` command regarding the extension required to execute a PHAR once compressed
- Handle the compression in `Box` instead of using the leaked `Box#phar`
- Make `Box` countable
- A few minor refactoring bits

Closes #186
@theofidry theofidry added this to the 3.0.0 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@theofidry