Skip to content

Commit

Permalink
refactor: Inline the pharaoh package (#895)
Browse files Browse the repository at this point in the history
The [pharaoh package](https://github.com/paragonie/pharaoh) is unfortunately no longer maintained. I offered several patches but in the end most of it had to be patched directly in Box.

I think there is a high risk of being a liability in the future and this is also making it harder to improve the diff & info Box commands.

In order to bring improvements, I think it's best to "inline" this package for now. Once the feature set desired is reached and the API more stable, it will still be possible to extract it or port back those elements.
  • Loading branch information
theofidry authored Mar 5, 2023
1 parent e89dfe8 commit fe8fc71
Show file tree
Hide file tree
Showing 7 changed files with 879 additions and 335 deletions.
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"laravel/serializable-closure": "^1.2.2",
"nikic/iter": "^2.2",
"nikic/php-parser": "^4.15.2",
"paragonie/pharaoh": "^0.6",
"paragonie/constant_time_encoding": "^2.6",
"phpdocumentor/reflection-docblock": "^5.3",
"psr/log": "^3.0",
"seld/jsonlint": "^1.9",
Expand Down
Loading

0 comments on commit fe8fc71

Please sign in to comment.